| commit | d1b3525b4126d7acad0493b62642b80b71442661 | |
| author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | |
| Sun, 15 Feb 2009 19:24:24 +0000 (15 23:24 +0400) | ||
| committer | Jeff Garzik <jgarzik@redhat.com> | |
| Mon, 16 Feb 2009 23:55:56 +0000 (16 18:55 -0500) | ||
| tree | e8b55a52e5a57f92b997f84365fa9a72ded106c8 | treesnapshot (tar.gz zip) |
| parent | d2f8d7ee1a9b4650b4e43325b321801264f7c37a | commitdiff |
libata-sff: fix 32-bit PIO ATAPI regression
Commit 871af1210f13966ab911ed2166e4ab2ce775b99d (libata: Add 32bit
PIO support) has caused all kinds of errors on the ATAPI devices, so
it has been empirically proven that one shouldn't try to read/write
an extra data word when a device is not expecting it already. "Don't
do it then"; however, still use a chance to do 32-bit read/write one
last time when there are exactly 3 trailing bytes.
Oh, and stop pointlessly swapping the bytes to and fro on big-endian
machines by using io*_rep() accessors which shouldn't byte-swap.
This patch should fix the kernel.org bug #12609.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Commit 871af1210f13966ab911ed2166e4ab2ce775b99d (libata: Add 32bit
PIO support) has caused all kinds of errors on the ATAPI devices, so
it has been empirically proven that one shouldn't try to read/write
an extra data word when a device is not expecting it already. "Don't
do it then"; however, still use a chance to do 32-bit read/write one
last time when there are exactly 3 trailing bytes.
Oh, and stop pointlessly swapping the bytes to and fro on big-endian
machines by using io*_rep() accessors which shouldn't byte-swap.
This patch should fix the kernel.org bug #12609.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| drivers/ata/libata-sff.c | diffblobblamehistory |