| commit | c86d1b8ae622e1ea5d20e98bd72fbd7d9dd69016 | |
| author | Mike Snitzer <snitzer@redhat.com> | |
| Thu, 3 Jun 2010 17:34:52 +0000 (3 11:34 -0600) | ||
| committer | Jens Axboe <jaxboe@fusionio.com> | |
| Fri, 4 Jun 2010 11:47:06 +0000 (4 13:47 +0200) | ||
| tree | 92353647c38f99ee4b8bf6a29b9ae632c7be14e7 | treesnapshot (tar.gz zip) |
| parent | ff9da691c0498ff81fdd014e7a0731dab2337dac | commitdiff |
block: avoid unconditionally freeing previously allocated request_queue
On blk_init_allocated_queue_node failure, only free the request_queue if
it is wasn't previously allocated outside the block layer
(e.g. blk_init_queue_node was blk_init_allocated_queue_node caller).
This addresses an interface bug introduced by the following commit:
01effb0 block: allow initialization of previously allocated
request_queue
Otherwise the request_queue may be free'd out from underneath a caller
that is managing the request_queue directly (e.g. caller uses
blk_alloc_queue + blk_init_allocated_queue_node).
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
On blk_init_allocated_queue_node failure, only free the request_queue if
it is wasn't previously allocated outside the block layer
(e.g. blk_init_queue_node was blk_init_allocated_queue_node caller).
This addresses an interface bug introduced by the following commit:
01effb0 block: allow initialization of previously allocated
request_queue
Otherwise the request_queue may be free'd out from underneath a caller
that is managing the request_queue directly (e.g. caller uses
blk_alloc_queue + blk_init_allocated_queue_node).
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
| block/blk-core.c | diffblobblamehistory |