| commit | c6e9f8086227d824a45de8b0d9f626d66a30c6b0 | |
| author | Wim Van Sebroeck <wim@iguana.be> | |
| Wed, 15 Oct 2008 08:53:06 +0000 (15 08:53 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Sat, 13 Dec 2008 23:29:36 +0000 (13 15:29 -0800) | ||
| tree | b4fd6acbf1077b9d8618fbd76671211ad1284043 | treesnapshot (tar.gz zip) |
| parent | c832f62d3d057abfc1125621c80ede5840cf7aef | commitdiff |
ib700wdt.c - fix buffer_underflow bug
commit 7c2500f17d65092d93345f3996cf82ebca17e9ff upstream.
This fixes Bug 11399:
if ibwdt_set_heartbeat(int t) is called with value 30 then
the check "if ((t < 0) || (t > 30))" in ibwdt_set_heartbeat
is not going to fail because t == 30, but in the loop, the
check wd_times[i] > t is never going to be true because
none of the wd_times are greater than the value of t (i.e. 30).
So we are exiting the loop with i == -1 and therefore setting
wd_margin to -1 which is wrong.
Reported-by: Zvonimir Rakamaric <zrakamar@cs.ubc.ca>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 7c2500f17d65092d93345f3996cf82ebca17e9ff upstream.
This fixes Bug 11399:
if ibwdt_set_heartbeat(int t) is called with value 30 then
the check "if ((t < 0) || (t > 30))" in ibwdt_set_heartbeat
is not going to fail because t == 30, but in the loop, the
check wd_times[i] > t is never going to be true because
none of the wd_times are greater than the value of t (i.e. 30).
So we are exiting the loop with i == -1 and therefore setting
wd_margin to -1 which is wrong.
Reported-by: Zvonimir Rakamaric <zrakamar@cs.ubc.ca>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/watchdog/ib700wdt.c | diffblobblamehistory |