| commit | c6e8c6ccf96e9249805d0e9828b994f4c926ad51 | |
| author | KaiGai Kohei <kaigai@ak.jp.nec.com> | |
| Thu, 29 Jun 2006 14:33:02 +0000 (29 15:33 +0100) | ||
| committer | David Woodhouse <dwmw2@infradead.org> | |
| Thu, 29 Jun 2006 14:33:02 +0000 (29 15:33 +0100) | ||
| tree | 0db9c602c20a94d9afbd555a131805de60e75ed2 | treesnapshot (tar.gz zip) |
| parent | ea9b6dcc152f09c207117ab121d4fa03d2db282a | commitdiff |
[JFFS2][XATTR] Fix xd->refcnt race condition
When xd->refcnt is checked whether this xdatum should be released
or not, atomic_dec_and_lock() is used to ensure holding the
c->erase_completion_lock.
This fix change a specification of delete_xattr_datum().
Previously, it's only called when xd->refcnt equals zero.
(calling it with positive xd->refcnt cause a BUG())
If you applied this patch, the function checks whether
xd->refcnt is zero or not under the spinlock if necessary.
Then, it marks xd DEAD flahs and links with xattr_dead_list
or releases it immediately when xd->refcnt become zero.
Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
When xd->refcnt is checked whether this xdatum should be released
or not, atomic_dec_and_lock() is used to ensure holding the
c->erase_completion_lock.
This fix change a specification of delete_xattr_datum().
Previously, it's only called when xd->refcnt equals zero.
(calling it with positive xd->refcnt cause a BUG())
If you applied this patch, the function checks whether
xd->refcnt is zero or not under the spinlock if necessary.
Then, it marks xd DEAD flahs and links with xattr_dead_list
or releases it immediately when xd->refcnt become zero.
Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
| fs/jffs2/xattr.c | diffblobblamehistory |