| commit | c36531b9b2e00d9715c3a0f5788ac5311435e078 | |
| author | Mike McCormack <mikem@ring3k.org> | |
| Thu, 31 Dec 2009 00:55:31 +0000 (31 00:55 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 7 Jan 2010 04:26:14 +0000 (6 20:26 -0800) | ||
| tree | 54aeae5ce9b08d05370a6c96ddf0f27dadb1452c | treesnapshot (tar.gz zip) |
| parent | c32bbff81c04096c7888aed3946ee90fdbfbc3a3 | commitdiff |
sky2: Lock transmit queue while disabling device
netif_device_detach() does not take the tx_lock, so it's possible that
a call to sky2_xmit_frame is still in progress after
netif_device_detach() is complete.
Take netif_tx_lock() to make sure all transmits have stopped while
we're disabling the devices and that no other CPU is still
transmitting a frame after we've disabling the device.
Proposed fix for "sky2 panic under load" reported by Berck E. Nash.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
netif_device_detach() does not take the tx_lock, so it's possible that
a call to sky2_xmit_frame is still in progress after
netif_device_detach() is complete.
Take netif_tx_lock() to make sure all transmits have stopped while
we're disabling the devices and that no other CPU is still
transmitting a frame after we've disabling the device.
Proposed fix for "sky2 panic under load" reported by Berck E. Nash.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/sky2.c | diffblobblamehistory |