TTY: drop driver reference in tty_open fail path
commitbebd46c74cf5d8c7d4972f543cafa0ee20b184f9
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:42 +0000 (12 11:32 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:42:11 +0000 (11 09:42 -0800)
tree247c6632a127a58c112879d1d4f9d5a6831b1c8c
parent436318f9b483fa56bbecd8316b921f5876eddc14
TTY: drop driver reference in tty_open fail path

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/tty_io.c