| commit | bae94dc39e9530842379208c4406512d34dc7ef3 | |
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | |
| Thu, 7 Oct 2010 06:33:00 +0000 (7 03:33 -0300) | ||
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | |
| Thu, 21 Oct 2010 03:17:46 +0000 (21 01:17 -0200) | ||
| tree | 309b10639370e4bee3036ad960c2041abeecacb3 | treesnapshot (tar.gz zip) |
| parent | 955e6ed843ddddb57cf599584574c505175cd86f | commitdiff |
[media] cx231xx-417: Fix a gcc warning
gcc didn't like to have i++ inside a complex operation:
drivers/media/video/cx231xx/cx231xx-417.c: In function ‘cx231xx_load_firmware’:
drivers/media/video/cx231xx/cx231xx-417.c:1059: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1061: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1063: warning: operation on ‘i’ may be undefined
Btw, I agree with gcc, as we're using i and i++ at the same operation and,
depending on how optimization may occur, it may produce a wrong code.
While here, fix CodingStyle issues on the changed code.
Acked-by: Sri Deevi <Srinivasa.Deevi@conexant.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
gcc didn't like to have i++ inside a complex operation:
drivers/media/video/cx231xx/cx231xx-417.c: In function ‘cx231xx_load_firmware’:
drivers/media/video/cx231xx/cx231xx-417.c:1059: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1061: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1063: warning: operation on ‘i’ may be undefined
Btw, I agree with gcc, as we're using i and i++ at the same operation and,
depending on how optimization may occur, it may produce a wrong code.
While here, fix CodingStyle issues on the changed code.
Acked-by: Sri Deevi <Srinivasa.Deevi@conexant.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| drivers/media/video/cx231xx/cx231xx-417.c | diffblobblamehistory |