virtio: console: Fix poll blocking even though there is data to read
commitba4de7fd43bb21be634a39b0de274cfb9b19fd83
authorHans de Goede <hdegoede@redhat.com>
Thu, 16 Sep 2010 09:13:08 +0000 (16 14:43 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Sep 2010 00:18:20 +0000 (26 17:18 -0700)
tree85f45c50a7a7c9fc97ce04bb630f4c7cc128b46f
parentd4f5d4c1a4f45e69deb3bcf727e511b0637a72d1
virtio: console: Fix poll blocking even though there is data to read

commit 6df7aadcd9290807c464675098b5dd2dc9da5075 upstream.

I found this while working on a Linux agent for spice, the symptom I was
seeing was select blocking on the spice vdagent virtio serial port even
though there were messages queued up there.

virtio_console's port_fops_poll checks port->inbuf != NULL to determine
if read won't block. However if an application reads enough bytes from
inbuf through port_fops_read, to empty the current port->inbuf,
port->inbuf will be NULL even though there may be buffers left in the
virtqueue.

This causes poll() to block even though there is data to be read,
this patch fixes this by using will_read_block(port) instead of the
port->inbuf != NULL check.

Signed-off-By: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/virtio_console.c