| commit | b9fa1fbf98178c8bbda23ff1d3ed0731bb3c0bd1 | |
| author | Rasesh Mody <rmody@brocade.com> | |
| Fri, 16 Sep 2011 15:06:48 +0000 (16 15:06 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Sat, 17 Sep 2011 04:47:57 +0000 (17 00:47 -0400) | ||
| tree | 7562913799f3ec165d2e0befb43e7e5463dac7c2 | treesnapshot (tar.gz zip) |
| parent | 3fb9852f98ffb4cdd3bad6eb50b1a6d58cee1298 | commitdiff |
bna: Eliminate Small Race Condition Window in RX Path
Change details:
- In a continuous sequence of ifconfig up/down operations, there is a small
window of race between bnad_set_rx_mode() and bnad_cleanup_rx() while the
former tries to access rx_info->rx & the latter sets it to NULL. This race
could lead to bna_rx_mode_set() being called with a NULL (rx_info->rx)
pointer and a crash.
- Hold bnad->bna_lock while setting / unsetting rx_info->rx in bnad_setup_rx()
& bnad_cleanup_rx(), thereby eliminating the race described above.
Signed-off-by: Gurunatha Karaje <gkaraje@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Change details:
- In a continuous sequence of ifconfig up/down operations, there is a small
window of race between bnad_set_rx_mode() and bnad_cleanup_rx() while the
former tries to access rx_info->rx & the latter sets it to NULL. This race
could lead to bna_rx_mode_set() being called with a NULL (rx_info->rx)
pointer and a crash.
- Hold bnad->bna_lock while setting / unsetting rx_info->rx in bnad_setup_rx()
& bnad_cleanup_rx(), thereby eliminating the race described above.
Signed-off-by: Gurunatha Karaje <gkaraje@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/brocade/bna/bnad.c | diffblobblamehistory |