| commit | ac89db9934244f86cd8e58704a8bcf4ba8b1e893 | |
| author | Jean Delvare <khali@linux-fr.org> | |
| Sun, 31 Jan 2010 04:03:23 +0000 (31 04:03 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 15 Mar 2010 16:06:12 +0000 (15 09:06 -0700) | ||
| tree | 114a3b37827418bec6e9a2879485ff56b47614c5 | treesnapshot (tar.gz zip) |
| parent | 44fc910605e7b0ece4b2151309d6edbefa96517a | commitdiff |
macintosh/hwmon/ams: Fix device removal sequence
commit 98ceb75c7c14eada76b0aa9f03a635a735cee3cb upstream.
Some code that is in ams_exit() (the module exit code) should instead
be called when the device (not module) is removed. It probably doesn't
make much of a difference in the PMU case, but in the I2C case it does
matter.
I make no guarantee that my fix isn't racy, I'm not familiar enough
with the ams driver code to tell for sure.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stelian Pop <stelian@popies.net>
Cc: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 98ceb75c7c14eada76b0aa9f03a635a735cee3cb upstream.
Some code that is in ams_exit() (the module exit code) should instead
be called when the device (not module) is removed. It probably doesn't
make much of a difference in the PMU case, but in the I2C case it does
matter.
I make no guarantee that my fix isn't racy, I'm not familiar enough
with the ams driver code to tell for sure.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stelian Pop <stelian@popies.net>
Cc: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/hwmon/ams/ams-core.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams-i2c.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams-pmu.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams.h | diffblobblamehistory |