[PATCH] oom: fix constraint deadlock
commitab6823b4e00d05cd7233dae4c5e6ac80908ad059
authorDavid Rientjes <rientjes@google.com>
Sun, 6 May 2007 21:50:00 +0000 (6 14:50 -0700)
committerChris Wright <chrisw@sous-sol.org>
Wed, 23 May 2007 21:32:43 +0000 (23 14:32 -0700)
tree150245cc0225a1c2d48e4b22610e5d29320f4804
parentd28d851323561a4e2a1905291fcaedab6a6b408e
[PATCH] oom: fix constraint deadlock

Fixes a deadlock in the OOM killer for allocations that are not
__GFP_HARDWALL.

Before the OOM killer checks for the allocation constraint, it takes
callback_mutex.

constrained_alloc() iterates through each zone in the allocation zonelist
and calls cpuset_zone_allowed_softwall() to determine whether an allocation
for gfp_mask is possible.  If a zone's node is not in the OOM-triggering
task's mems_allowed, it is not exiting, and we did not fail on a
__GFP_HARDWALL allocation, cpuset_zone_allowed_softwall() attempts to take
callback_mutex to check the nearest exclusive ancestor of current's cpuset.
 This results in deadlock.

We now take callback_mutex after iterating through the zonelist since we
don't need it yet.

Cc: Andi Kleen <ak@suse.de>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Christoph Lameter <clameter@engr.sgi.com>
Cc: Martin J. Bligh <mbligh@mbligh.org>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
mm/oom_kill.c