| commit | a2abc1310ff689486730215fcea629b74b01abe4 | |
| author | Eric Dumazet <edumazet@google.com> | |
| Thu, 17 May 2012 23:52:26 +0000 (17 23:52 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Sat, 9 Jun 2012 15:33:03 +0000 (10 00:33 +0900) | ||
| tree | 73d57e9ac12a1180a4af0a95c090e1aa4425125f | treesnapshot (tar.gz zip) |
| parent | 45d21c136849cda838e77928d544fc7cd9d6239c | commitdiff |
pktgen: fix module unload for good
[ Upstream commit d4b1133558e0d417342d5d2c49e4c35b428ff20d ]
commit c57b5468406 (pktgen: fix crash at module unload) did a very poor
job with list primitives.
1) list_splice() arguments were in the wrong order
2) list_splice(list, head) has undefined behavior if head is not
initialized.
3) We should use the list_splice_init() variant to clear pktgen_threads
list.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[ Upstream commit d4b1133558e0d417342d5d2c49e4c35b428ff20d ]
commit c57b5468406 (pktgen: fix crash at module unload) did a very poor
job with list primitives.
1) list_splice() arguments were in the wrong order
2) list_splice(list, head) has undefined behavior if head is not
initialized.
3) We should use the list_splice_init() variant to clear pktgen_threads
list.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| net/core/pktgen.c | diffblobblamehistory |