| commit | a0497206defc4bc38a6bef6cb3b9bbed6be3ff50 | |
| author | Martin Fuzzey <mfuzzey@gmail.com> | |
| Thu, 11 Feb 2010 13:50:31 +0000 (11 10:50 -0300) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 15 Mar 2010 15:49:32 +0000 (15 08:49 -0700) | ||
| tree | 035227d3df27f6f92cdcf371d6a24c0066c5a65f | treesnapshot (tar.gz zip) |
| parent | bec3dfd4c9e939eea52a72d20d4493233dde41eb | commitdiff |
V4L/DVB: Video : pwc : Fix regression in pwc_set_shutter_speed caused by bad constant => sizeof conversion.
commit 53f68607caba85db9a73846ccd289e4b7fa96295 upstream.
Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.
Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.
All other uses of sizeof checked and are ok.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 53f68607caba85db9a73846ccd289e4b7fa96295 upstream.
Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.
Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.
All other uses of sizeof checked and are ok.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/media/video/pwc/pwc-ctrl.c | diffblobblamehistory |