cifs: remove bogus first_time check in NTLMv2 session setup code
commit9fcb9b3b8cf44cdfb2e6ac9b57252b960d7c22ac
authorJeff Layton <jlayton@redhat.com>
Wed, 16 Jun 2010 17:40:18 +0000 (16 13:40 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:29:24 +0000 (2 10:29 -0700)
tree5ae1b3964b12c422f0026e7d17f1ffb1ba245cf0
parente779a25d7285a229fc93751db47d80d4c2dd9045
cifs: remove bogus first_time check in NTLMv2 session setup code

commit 8a224d489454b7457105848610cfebebdec5638d upstream.

This bug appears to be the result of a cut-and-paste mistake from the
NTLMv1 code. The function to generate the MAC key was commented out, but
not the conditional above it. The conditional then ended up causing the
session setup key not to be copied to the buffer unless this was the
first session on the socket, and that made all but the first NTLMv2
session setup fail.

Fix this by removing the conditional and all of the commented clutter
that made it difficult to see.

Reported-by: Gunther Deschner <gdeschne@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/cifs/sess.c