thinkpad-acpi: restrict access to some firmware LEDs
commit9a17577815aa30e463af2ef1748947bd4b0a8cec
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Sat, 18 Apr 2009 00:19:54 +0000 (17 21:19 -0300)
committerHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Sat, 18 Apr 2009 00:19:54 +0000 (17 21:19 -0300)
tree7490d3cc38c2a75cfe125cb232c95d11b53b0506
parent1b5f755958c4dbfb549e78a1f822cdf1b67d7b23
thinkpad-acpi: restrict access to some firmware LEDs

Some of the ThinkPad LEDs indicate critical conditions that can cause
data loss or cause hardware damage when ignored (e.g. force-ejecting
a powered up bay; ignoring a failing battery, or empty battery; force-
undocking with the dock buses still active, etc).

On almost all ThinkPads, LED access is write-only, and the firmware
usually does fire-and-forget signaling on them, so you effectively
lose whatever message the firmware was trying to convey to the user
when you override the LED state, without any chance to restore it.

Restrict access to all LEDs that can convey important alarms, or that
could mislead the user into incorrectly operating the hardware.  This
will make the Lenovo engineers less unhappy about the whole issue.

Allow users that really want it to still control all LEDs, it is the
unaware user that we have to worry about.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Documentation/laptops/thinkpad-acpi.txt
drivers/platform/x86/Kconfig
drivers/platform/x86/thinkpad_acpi.c