sched/x86: Fix overflow in cyc2ns_offset
commit9993bc635d01a6ee7f6b833b4ee65ce7c06350b1
authorSalman Qazi <sqazi@google.com>
Sat, 10 Mar 2012 00:41:01 +0000 (9 16:41 -0800)
committerIngo Molnar <mingo@elte.hu>
Tue, 13 Mar 2012 15:27:51 +0000 (13 16:27 +0100)
tree9e40c69ef513fc0a57c03a05a68afc6711418ed8
parent47258cf3c4aa5d56e678bafe0dd0d03ddd980b88
sched/x86: Fix overflow in cyc2ns_offset

When a machine boots up, the TSC generally gets reset.  However,
when kexec is used to boot into a kernel, the TSC value would be
carried over from the previous kernel.  The computation of
cycns_offset in set_cyc2ns_scale is prone to an overflow, if the
machine has been up more than 208 days prior to the kexec.  The
overflow happens when we multiply *scale, even though there is
enough room to store the final answer.

We fix this issue by decomposing tsc_now into the quotient and
remainder of division by CYC2NS_SCALE_FACTOR and then performing
the multiplication separately on the two components.

Refactor code to share the calculation with the previous
fix in __cycles_2_ns().

Signed-off-by: Salman Qazi <sqazi@google.com>
Acked-by: John Stultz <john.stultz@linaro.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Turner <pjt@google.com>
Cc: john stultz <johnstul@us.ibm.com>
Link: http://lkml.kernel.org/r/20120310004027.19291.88460.stgit@dungbeetle.mtv.corp.google.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/timer.h
arch/x86/kernel/tsc.c
include/linux/kernel.h