| commit | 994fed2dd2166f86b62ec53c7424660145f138ee | |
| author | Stefan Weil <weil@mail.berlios.de> | |
| Sun, 30 Jan 2011 20:41:44 +0000 (30 21:41 +0100) | ||
| committer | Ralf Baechle <ralf@linux-mips.org> | |
| Mon, 14 Mar 2011 20:07:26 +0000 (14 21:07 +0100) | ||
| tree | 693b4a0483d0a4ec10a4b2ab911213c4b892b7a2 | treesnapshot (tar.gz zip) |
| parent | d3ce0e98b7fe17bb1dec9f6d7c50213db01e7189 | commitdiff |
MIPS: Loongson: Fix potentially wrong string handling
This error was reported by cppcheck:
arch/mips/loongson/common/machtype.c:56: error: Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
If strncpy copied MACHTYPE_LEN bytes, the destination string str
was not terminated.
The patch adds one more byte to str and makes sure that this byte is
always 0.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Arnaud Patard <apatard@mandriva.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/2053/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This error was reported by cppcheck:
arch/mips/loongson/common/machtype.c:56: error: Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
If strncpy copied MACHTYPE_LEN bytes, the destination string str
was not terminated.
The patch adds one more byte to str and makes sure that this byte is
always 0.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Arnaud Patard <apatard@mandriva.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/2053/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
| arch/mips/loongson/common/machtype.c | diffblobblamehistory |