| commit | 98ceb75c7c14eada76b0aa9f03a635a735cee3cb | |
| author | Jean Delvare <khali@linux-fr.org> | |
| Sun, 31 Jan 2010 04:03:23 +0000 (31 04:03 +0000) | ||
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Wed, 3 Feb 2010 06:39:49 +0000 (3 17:39 +1100) | ||
| tree | d514b307399db60cdbc1fd9461e8b5af5655ca0a | treesnapshot (tar.gz zip) |
| parent | 33a470f6d5e1879c26f16f6b34dc09f82d44f6e9 | commitdiff |
macintosh/hwmon/ams: Fix device removal sequence
Some code that is in ams_exit() (the module exit code) should instead
be called when the device (not module) is removed. It probably doesn't
make much of a difference in the PMU case, but in the I2C case it does
matter.
I make no guarantee that my fix isn't racy, I'm not familiar enough
with the ams driver code to tell for sure.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stelian Pop <stelian@popies.net>
Cc: Michael Hanselmann <linux-kernel@hansmi.ch>
Cc: stable@kernel.org
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Some code that is in ams_exit() (the module exit code) should instead
be called when the device (not module) is removed. It probably doesn't
make much of a difference in the PMU case, but in the I2C case it does
matter.
I make no guarantee that my fix isn't racy, I'm not familiar enough
with the ams driver code to tell for sure.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stelian Pop <stelian@popies.net>
Cc: Michael Hanselmann <linux-kernel@hansmi.ch>
Cc: stable@kernel.org
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| drivers/hwmon/ams/ams-core.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams-i2c.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams-pmu.c | diffblobblamehistory | |
| drivers/hwmon/ams/ams.h | diffblobblamehistory |