| commit | 984ecb9293b77901947f3ade5f7e1a70bfc7d940 | |
| author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | |
| Mon, 10 Oct 2011 14:27:02 +0000 (10 07:27 -0700) | ||
| committer | John W. Linville <linville@tuxdriver.com> | |
| Fri, 14 Oct 2011 18:48:11 +0000 (14 14:48 -0400) | ||
| tree | 478b235d7c457350049ddf6ee91425e37f050696 | treesnapshot (tar.gz zip) |
| parent | b319d3eb964a602dd1f77bd04b033c40f896e06f | commitdiff |
iwlagn: fix a race in the unmapping of the TFDs
While inspecting the code, I saw that iwl_tx_queue_unmap modifies
the read pointer of the Tx queue without taking any locks. This means
that it can race with the reclaim flow. This can possibly lead to
a DMA warning complaining that we unmap the same buffer twice.
This is more a W/A than a fix since it is really weird to take
sta_lock inside iwl_tx_queue_unmap, but it can help until we revamp
the locking model in the transport layer.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
While inspecting the code, I saw that iwl_tx_queue_unmap modifies
the read pointer of the Tx queue without taking any locks. This means
that it can race with the reclaim flow. This can possibly lead to
a DMA warning complaining that we unmap the same buffer twice.
This is more a W/A than a fix since it is really weird to take
sta_lock inside iwl_tx_queue_unmap, but it can help until we revamp
the locking model in the transport layer.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| drivers/net/wireless/iwlwifi/iwl-trans-pcie.c | diffblobblamehistory |