| commit | 9817e237916af43481820974759da79df7487c6f | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Tue, 14 Apr 2009 02:44:11 +0000 (14 02:44 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Sat, 2 May 2009 17:57:20 +0000 (2 10:57 -0700) | ||
| tree | bf52c0f0dd4077a9ccda0fabbf9239bf576a7466 | treesnapshot (tar.gz zip) |
| parent | 8967d37deb2ce9a2e5d0685680e6ea8eea85deb3 | commitdiff |
thinkpad-acpi: fix LED blinking through timer trigger
commit 75bd3bf2ade9d548be0d2bde60b5ee0fdce0b127 upstream.
The set_blink hook code in the LED subdriver would never manage to get
a LED to blink, and instead it would just turn it on. The consequence
of this is that the "timer" trigger would not cause the LED to blink
if given default parameters.
This problem exists since 2.6.26-rc1.
To fix it, switch the deferred LED work handling to use the
thinkpad-acpi-specific LED status (off/on/blink) directly.
This also makes the code easier to read, and to extend later.
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 75bd3bf2ade9d548be0d2bde60b5ee0fdce0b127 upstream.
The set_blink hook code in the LED subdriver would never manage to get
a LED to blink, and instead it would just turn it on. The consequence
of this is that the "timer" trigger would not cause the LED to blink
if given default parameters.
This problem exists since 2.6.26-rc1.
To fix it, switch the deferred LED work handling to use the
thinkpad-acpi-specific LED status (off/on/blink) directly.
This also makes the code easier to read, and to extend later.
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/misc/thinkpad_acpi.c | diffblobblamehistory |