| commit | 92dc07b1f988e8c237a38e23be660b9b8533e6fd | |
| author | Roland McGrath <roland@redhat.com> | |
| Sat, 7 Feb 2009 01:34:07 +0000 (6 17:34 -0800) | ||
| committer | Roland McGrath <roland@redhat.com> | |
| Sat, 7 Feb 2009 01:34:07 +0000 (6 17:34 -0800) | ||
| tree | 4a689fbb465d7302b105678152170d8665f56ae7 | treesnapshot (tar.gz zip) |
| parent | 6cec50838ed04a9833fb5549f698d3756bbe7e72 | commitdiff |
elf core dump: fix get_user use
The elf_core_dump() code does its work with set_fs(KERNEL_DS) in force,
so vma_dump_size() needs to switch back with set_fs(USER_DS) to safely
use get_user() for a normal user-space address.
Checking for VM_READ optimizes out the case where get_user() would fail
anyway. The vm_file check here was already superfluous given the control
flow earlier in the function, so that is a cleanup/optimization unrelated
to other changes but an obvious and trivial one.
Reported-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Roland McGrath <roland@redhat.com>
The elf_core_dump() code does its work with set_fs(KERNEL_DS) in force,
so vma_dump_size() needs to switch back with set_fs(USER_DS) to safely
use get_user() for a normal user-space address.
Checking for VM_READ optimizes out the case where get_user() would fail
anyway. The vm_file check here was already superfluous given the control
flow earlier in the function, so that is a cleanup/optimization unrelated
to other changes but an obvious and trivial one.
Reported-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Roland McGrath <roland@redhat.com>
| fs/binfmt_elf.c | diffblobblamehistory |