kallsyms: make KSYM_NAME_LEN include space for trailing '\0'
commit9281acea6a3687ff0f262e0be31eac34895b95d7
authorTejun Heo <htejun@gmail.com>
Tue, 17 Jul 2007 11:03:51 +0000 (17 04:03 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:03 +0000 (17 10:23 -0700)
treef060d6e4f6a5da1c82bc789104683d39377a2e9a
parentb45d52797432bd6b5d9786dbda940eb8d0b9ed06
kallsyms: make KSYM_NAME_LEN include space for trailing '\0'

KSYM_NAME_LEN is peculiar in that it does not include the space for the
trailing '\0', forcing all users to use KSYM_NAME_LEN + 1 when allocating
buffer.  This is nonsense and error-prone.  Moreover, when the caller
forgets that it's very likely to subtly bite back by corrupting the stack
because the last position of the buffer is always cleared to zero.

This patch increments KSYM_NAME_LEN by one and updates code accordingly.

* off-by-one bug in asm-powerpc/kprobes.h::kprobe_lookup_name() macro
  is fixed.

* Where MODULE_NAME_LEN and KSYM_NAME_LEN were used together,
  MODULE_NAME_LEN was treated as if it didn't include space for the
  trailing '\0'.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Paulo Marques <pmarques@grupopie.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/parisc/kernel/unwind.c
fs/proc/base.c
include/asm-powerpc/kprobes.h
include/linux/kallsyms.h
kernel/kallsyms.c
kernel/lockdep.c
kernel/module.c
kernel/time/timer_list.c
kernel/time/timer_stats.c
mm/slab.c
scripts/kallsyms.c