| commit | 90e2111a4feb6473082b723f83c6af730e06041a | |
| author | Alan Cox <alan@linux.intel.com> | |
| Tue, 4 May 2010 19:42:36 +0000 (4 20:42 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Wed, 26 May 2010 21:32:07 +0000 (26 14:32 -0700) | ||
| tree | 7364d056531f5b68eed1e0f9037ea6a9f934de21 | treesnapshot (tar.gz zip) |
| parent | fea3cd8871c7f5868eed8422f276a958e3d5d0b6 | commitdiff |
tty: Fix unbalanced BKL handling in error path
commit 77945febbe60a69e9dcab7f49d33a1aa1e436973 upstream.
Arnd noted:
After the "retry_open:" label, we first get the tty_mutex
and then the BKL. However a the end of tty_open, we jump
back to retry_open with the BKL still held. If we run into
this case, the tty_open function will be left with the BKL
still held.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 77945febbe60a69e9dcab7f49d33a1aa1e436973 upstream.
Arnd noted:
After the "retry_open:" label, we first get the tty_mutex
and then the BKL. However a the end of tty_open, we jump
back to retry_open with the BKL still held. If we run into
this case, the tty_open function will be left with the BKL
still held.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/char/tty_io.c | diffblobblamehistory |