| commit | 8e87b9b81b3c370f7e53c1ab6e1c3519ef37a644 | |
| author | Mikulas Patocka <mpatocka@redhat.com> | |
| Thu, 10 Dec 2009 23:51:54 +0000 (10 23:51 +0000) | ||
| committer | Alasdair G Kergon <agk@redhat.com> | |
| Thu, 10 Dec 2009 23:51:54 +0000 (10 23:51 +0000) | ||
| tree | 272a8532e12749c6c8419dcab0c341604646c571 | treesnapshot (tar.gz zip) |
| parent | 94e76572b5dd37b1f0f4b3742ee8a565daead932 | commitdiff |
dm snapshot: cope with chunk size larger than origin
Under some special conditions the snapshot hash_size is calculated as zero.
This patch instead sets a minimum value of 64, the same as for the
pending exception table.
rounddown_pow_of_two(0) is an undefined operation (it expands to shift
by -1). init_exception_table with an argument of 0 would fail with -ENOMEM.
The way to trigger the problem is to create a snapshot with a chunk size
that is larger than the origin device.
Cc: stable@kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Under some special conditions the snapshot hash_size is calculated as zero.
This patch instead sets a minimum value of 64, the same as for the
pending exception table.
rounddown_pow_of_two(0) is an undefined operation (it expands to shift
by -1). init_exception_table with an argument of 0 would fail with -ENOMEM.
The way to trigger the problem is to create a snapshot with a chunk size
that is larger than the origin device.
Cc: stable@kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
| drivers/md/dm-snap.c | diffblobblamehistory |