| commit | 8647af71d623671a020a54d860f77bc0fa2e606e | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Thu, 6 Mar 2008 23:41:50 +0000 (6 15:41 -0800) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 10 Mar 2008 23:38:01 +0000 (10 16:38 -0700) | ||
| tree | 6133f6e5e048adf9b5e2aee2b21c1f6a74b149c4 | treesnapshot (tar.gz zip) |
| parent | cdeeeae056a429e729ae9e914fa8142ee45bee93 | commitdiff |
PCI: rename DECLARE_PCI_DEVICE_TABLE to DEFINE_PCI_DEVICE_TABLE
a) DECLARE_PCI_DEVICE_TABLE is misnamed. It is used to *define* tables,
not to declare them. It should be called DEFINE_PCI_DEVICE_TABLE.
b) It's lame, anyway. We could implement any number of such helper
thingies, but we choose not to.
So I wouldn't go adding code which uses this thing until it has a correct
name, and until we've decided that we actually want to live with it.
From: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonas Bonn <jonas@southpole.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
a) DECLARE_PCI_DEVICE_TABLE is misnamed. It is used to *define* tables,
not to declare them. It should be called DEFINE_PCI_DEVICE_TABLE.
b) It's lame, anyway. We could implement any number of such helper
thingies, but we choose not to.
So I wouldn't go adding code which uses this thing until it has a correct
name, and until we've decided that we actually want to live with it.
From: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonas Bonn <jonas@southpole.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| Documentation/pci.txt | diffblobblamehistory | |
| include/linux/pci.h | diffblobblamehistory |