| commit | 84261923d3dddb766736023bead6fa07b7e218d5 | |
| author | Marcelo Tosatti <mtosatti@redhat.com> | |
| Wed, 17 Jun 2009 13:53:47 +0000 (17 10:53 -0300) | ||
| committer | Avi Kivity <avi@redhat.com> | |
| Sun, 28 Jun 2009 11:10:29 +0000 (28 14:10 +0300) | ||
| tree | 23a0c4af14dd9c548c5bcb457c74fdd980e2312e | treesnapshot (tar.gz zip) |
| parent | 29a4b9333bf9ffef12b3dd7cbf2e3dbe01152968 | commitdiff |
KVM: protect concurrent make_all_cpus_request
make_all_cpus_request contains a race condition which can
trigger false request completed status, as follows:
CPU0 CPU1
if (test_and_set_bit(req,&vcpu->requests))
.... if (test_and_set_bit(req,&vcpu->requests))
.. return
proceed to smp_call_function_many(wait=1)
Use a spinlock to serialize concurrent CPUs.
Cc: stable@kernel.org
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
make_all_cpus_request contains a race condition which can
trigger false request completed status, as follows:
CPU0 CPU1
if (test_and_set_bit(req,&vcpu->requests))
.... if (test_and_set_bit(req,&vcpu->requests))
.. return
proceed to smp_call_function_many(wait=1)
Use a spinlock to serialize concurrent CPUs.
Cc: stable@kernel.org
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
| include/linux/kvm_host.h | diffblobblamehistory | |
| virt/kvm/kvm_main.c | diffblobblamehistory |