| commit | 81dae6716f13e801cfe2035514e7aeb971b57492 | |
| author | matthieu castet <castet.matthieu@free.fr> | |
| Wed, 20 May 2009 08:42:33 +0000 (20 05:42 -0300) | ||
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | |
| Tue, 16 Jun 2009 21:21:09 +0000 (16 18:21 -0300) | ||
| tree | 20550dc21f1efefa556f7a046b31cb32b0ac2f21 | treesnapshot (tar.gz zip) |
| parent | a9b8fe30a6d2a49749327ff18c4daa488ef73ab3 | commitdiff |
V4L/DVB (11832): dibusb_mc: fix i2c to not corrupt eeprom in case of strange read pattern
dibusb_i2c_xfer seems to do things very dangerous :
it assumes that it get only write/read request or write request.
That means that read can be understood as write. For example a program
doing
file = open("/dev/i2c-x", O_RDWR);
ioctl(file, I2C_SLAVE, 0x50)
read(file, data, 10)
will corrupt the eeprom as it will be understood as a write.
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
dibusb_i2c_xfer seems to do things very dangerous :
it assumes that it get only write/read request or write request.
That means that read can be understood as write. For example a program
doing
file = open("/dev/i2c-x", O_RDWR);
ioctl(file, I2C_SLAVE, 0x50)
read(file, data, 10)
will corrupt the eeprom as it will be understood as a write.
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| drivers/media/dvb/dvb-usb/dibusb-common.c | diffblobblamehistory |