netfilter: h323: bug in parsing of ASN1 SEQOF field
commit7f96f975d3419d9155be5c82c6a1eac2f840b761
authorDavid Sterba <dsterba@suse.cz>
Mon, 4 Apr 2011 13:21:02 +0000 (4 15:21 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 20:02:37 +0000 (14 13:02 -0700)
tree30b9fbbf95596cf833c9b04f339679d85fdf57b8
parent0fc073e4b3b2cd9f5770190e585349adf9743ee3
netfilter: h323: bug in parsing of ASN1 SEQOF field

commit b4232a22776aa5d063f890d21ca69870dbbe431b upstream.

Static analyzer of clang found a dead store which appears to be a bug in
reading count of items in SEQOF field, only the lower byte of word is
stored. This may lead to corrupted read and communication shutdown.

The bug has been in the module since it's first inclusion into linux
kernel.

[Patrick: the bug is real, but without practical consequence since the
 largest amount of sequence-of members we parse is 30.]

Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/netfilter/nf_conntrack_h323_asn1.c