| commit | 7c66e9a5e6b0459c619562c5ad321071e2767faa | |
| author | Joseph Gruher <joseph.r.gruher@intel.com> | |
| Wed, 5 Jan 2011 21:00:20 +0000 (5 16:00 -0500) | ||
| committer | James Bottomley <James.Bottomley@suse.de> | |
| Mon, 24 Jan 2011 17:11:58 +0000 (24 11:11 -0600) | ||
| tree | 6262074d4bad042fe039bf11e84423e9908305e3 | treesnapshot (tar.gz zip) |
| parent | aa023b8b2fc09baeeb27af959ab38a8d684946bf | commitdiff |
[SCSI] scsi_dh_alua: fix submit_stpg return
submit_stpg() will always return failure so alua_activate() will report
failure via dm-multipath callback function. Even though the stpg fired
successfuly dm-multipath does not know and always fails to change the
valid path.
By returning SCSI_DH_OK we're now skipping alua_activate()'s call to
activate_complete 'fn'. But this is fine because stpg_endio() will call
it via h->callback_fn().
Signed-off-by: Joseph Gruher <joseph.r.gruher@intel.com>
Signed-off-by: Ilgu Hong <ilgu.hong@promise.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
submit_stpg() will always return failure so alua_activate() will report
failure via dm-multipath callback function. Even though the stpg fired
successfuly dm-multipath does not know and always fails to change the
valid path.
By returning SCSI_DH_OK we're now skipping alua_activate()'s call to
activate_complete 'fn'. But this is fine because stpg_endio() will call
it via h->callback_fn().
Signed-off-by: Joseph Gruher <joseph.r.gruher@intel.com>
Signed-off-by: Ilgu Hong <ilgu.hong@promise.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| drivers/scsi/device_handler/scsi_dh_alua.c | diffblobblamehistory |