| commit | 7910591c1c2663dd3f421f5a80fbd5c439af3aef | |
| author | Yinghai Lu <yinghai@kernel.org> | |
| Thu, 17 Mar 2011 03:01:07 +0000 (16 20:01 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 14 Apr 2011 20:02:04 +0000 (14 13:02 -0700) | ||
| tree | bdf7fb6eb31ddb8cb15ec4527b35becd92c3e276 | treesnapshot (tar.gz zip) |
| parent | 984814d5a002305f9f53ec8e8d3bbefc30a13583 | commitdiff |
watchdog: sp5100_tco.c: Check if firmware has set correct value in tcobase.
commit 90d241edd13bdeef70f264b569f7e150bf23621e upstream.
Stefano found SP5100 TCO watchdog driver using wrong address.
[ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
[ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1
and e820 said that range is RAM.
We should check if we can use that reading out. BIOS could just program wrong address there.
Reported-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by:Yinghai Lu <yinghai@kernel.org>
Acked-by: Mike Waychison <mikew@google.com>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 90d241edd13bdeef70f264b569f7e150bf23621e upstream.
Stefano found SP5100 TCO watchdog driver using wrong address.
[ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
[ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1
and e820 said that range is RAM.
We should check if we can use that reading out. BIOS could just program wrong address there.
Reported-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by:Yinghai Lu <yinghai@kernel.org>
Acked-by: Mike Waychison <mikew@google.com>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/watchdog/sp5100_tco.c | diffblobblamehistory |