| commit | 78a9c9c97455d0f8d2d2098b2252eb4bf65be799 | |
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | |
| Tue, 21 Jul 2009 10:11:39 +0000 (21 10:11 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 22 Jul 2009 18:24:28 +0000 (22 11:24 -0700) | ||
| tree | bfaf6250d11d9c1f00e99905135d82a27ab1edb5 | treesnapshot (tar.gz zip) |
| parent | 7b55a4a3f761db7daba1ac526ef60f64f5c53689 | commitdiff |
register at91_ether using platform_driver_probe
at91ether_probe lives in .init.text, so using platform_driver_register
to register it is wrong because binding a device after the init memory
is discarded (e.g. via sysfs) results in an oops.
As requested by David Brownell platform_driver_probe is used instead of
moving the probe function to .devinit.text as proposed initially.
This saves some memory, but devices registered after the driver is
probed are not bound (probably there are none) and binding via sysfs
isn't possible.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Andrew Victor <linux@maxim.org.za>
Signed-off-by: David S. Miller <davem@davemloft.net>
at91ether_probe lives in .init.text, so using platform_driver_register
to register it is wrong because binding a device after the init memory
is discarded (e.g. via sysfs) results in an oops.
As requested by David Brownell platform_driver_probe is used instead of
moving the probe function to .devinit.text as proposed initially.
This saves some memory, but devices registered after the driver is
probed are not bound (probably there are none) and binding via sysfs
isn't possible.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Andrew Victor <linux@maxim.org.za>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/arm/at91_ether.c | diffblobblamehistory |