| commit | 6ebdf777ba034d2b54c99f28a4b18dabf286d8e5 | |
| author | Matthew Garrett <mjg@redhat.com> | |
| Thu, 15 Jul 2010 15:44:00 +0000 (15 11:44 -0400) | ||
| committer | Dave Jones <davej@redhat.com> | |
| Tue, 3 Aug 2010 17:47:02 +0000 (3 13:47 -0400) | ||
| tree | 7e8f56588cbb44657a801a23e1589308f0cc553e | treesnapshot (tar.gz zip) |
| parent | 0d9715d64fe118dd0957a29e344972b8d3f960e7 | commitdiff |
[CPUFREQ] Fix PCC driver error path
The PCC cpufreq driver unmaps the mailbox address range if any CPUs fail to
initialise, but doesn't do anything to remove the registered CPUs from the
cpufreq core resulting in failures further down the line. We're better off
simply returning a failure - the cpufreq core will unregister us cleanly if
we end up with no successfully registered CPUs. Tidy up the failure path
and also add a sanity check to ensure that the firmware gives us a realistic
frequency - the core deals badly with that being set to 0.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
Signed-off-by: Dave Jones <davej@redhat.com>
The PCC cpufreq driver unmaps the mailbox address range if any CPUs fail to
initialise, but doesn't do anything to remove the registered CPUs from the
cpufreq core resulting in failures further down the line. We're better off
simply returning a failure - the cpufreq core will unregister us cleanly if
we end up with no successfully registered CPUs. Tidy up the failure path
and also add a sanity check to ensure that the firmware gives us a realistic
frequency - the core deals badly with that being set to 0.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
Signed-off-by: Dave Jones <davej@redhat.com>
| arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c | diffblobblamehistory |