| commit | 63ec731a4dcb77487b1caedf9b3a8d295c3f1ad7 | |
| author | Julia Lawall <julia@diku.dk> | |
| Sat, 15 May 2010 09:46:12 +0000 (15 11:46 +0200) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 2 Aug 2010 17:29:41 +0000 (2 10:29 -0700) | ||
| tree | 4b3f9e77f3e2924d4a2d11347ee520de19f5590c | treesnapshot (tar.gz zip) |
| parent | 7501f55f2be0c60f3ec5efe8c15a790665e7ac1a | commitdiff |
SCSI: aacraid: Eliminate use after free
commit 8a52da632ceb9d8b776494563df579e87b7b586b upstream.
The debugging code using the freed structure is moved before the kfree.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@free@
expression E;
position p;
@@
kfree@p(E)
@@
expression free.E, subE<=free.E, E1;
position free.p;
@@
kfree@p(E)
...
(
subE = E1
|
* E
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
commit 8a52da632ceb9d8b776494563df579e87b7b586b upstream.
The debugging code using the freed structure is moved before the kfree.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@free@
expression E;
position p;
@@
kfree@p(E)
@@
expression free.E, subE<=free.E, E1;
position free.p;
@@
kfree@p(E)
...
(
subE = E1
|
* E
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| drivers/scsi/aacraid/commctrl.c | diffblobblamehistory |