| commit | 62965d8347a071c72f4dae96e65be5fb68dd052f | |
| author | Jan Kara <jack@suse.cz> | |
| Tue, 1 Dec 2009 15:53:06 +0000 (1 16:53 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Fri, 18 Dec 2009 22:05:39 +0000 (18 14:05 -0800) | ||
| tree | 8692745fa597bed740e9d824eaec46f815a9d271 | treesnapshot (tar.gz zip) |
| parent | ad496b34c6835a89dd3a8f6c07dfcf8a0dd7c277 | commitdiff |
ext3: Fix data / filesystem corruption when write fails to copy data
commit 68eb3db08344286733adac48304d9fb7a0e53b27 upstream.
When ext3_write_begin fails after allocating some blocks or
generic_perform_write fails to copy data to write, we truncate blocks already
instantiated beyond i_size. Although these blocks were never inside i_size, we
have to truncate pagecache of these blocks so that corresponding buffers get
unmapped. Otherwise subsequent __block_prepare_write (called because we are
retrying the write) will find the buffers mapped, not call ->get_block, and
thus the page will be backed by already freed blocks leading to filesystem and
data corruption.
Reported-by: James Y Knight <foom@fuhm.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 68eb3db08344286733adac48304d9fb7a0e53b27 upstream.
When ext3_write_begin fails after allocating some blocks or
generic_perform_write fails to copy data to write, we truncate blocks already
instantiated beyond i_size. Although these blocks were never inside i_size, we
have to truncate pagecache of these blocks so that corresponding buffers get
unmapped. Otherwise subsequent __block_prepare_write (called because we are
retrying the write) will find the buffers mapped, not call ->get_block, and
thus the page will be backed by already freed blocks leading to filesystem and
data corruption.
Reported-by: James Y Knight <foom@fuhm.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| fs/ext3/inode.c | diffblobblamehistory |