| commit | 6057912d7baad31be9819518674ffad349a065b1 | |
| author | Julia Lawall <julia@diku.dk> | |
| Sun, 13 Dec 2009 05:47:04 +0000 (13 05:47 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 14 Dec 2009 03:56:35 +0000 (13 19:56 -0800) | ||
| tree | 73cf227b2f00b170041c9e2f7ea8dfa6dd9af38b | treesnapshot (tar.gz zip) |
| parent | 2447f2f3c38d3058d50de93df225ee6ad295932b | commitdiff |
drivers/net/usb: Correct code taking the size of a pointer
sizeof(dev->dev_addr) is the size of a pointer. A few lines above, the
size of this field is obtained using netdev->addr_len for a call to memcpy,
so do the same here.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *x;
expression f;
type T;
@@
*f(...,(T)x,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
sizeof(dev->dev_addr) is the size of a pointer. A few lines above, the
size of this field is obtained using netdev->addr_len for a call to memcpy,
so do the same here.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *x;
expression f;
type T;
@@
*f(...,(T)x,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/usb/rtl8150.c | diffblobblamehistory |