| commit | 601139e08339b15997c6ae638dc5bf42c51ea204 | |
| author | Trent Piepho <xyzzy@speakeasy.org> | |
| Mon, 12 Jan 2009 16:09:46 +0000 (12 13:09 -0300) | ||
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | |
| Thu, 29 Jan 2009 10:35:38 +0000 (29 08:35 -0200) | ||
| tree | 42e8e2b998b3f020ed7049ec9bc03f3439e79c0a | treesnapshot (tar.gz zip) |
| parent | 45bdcefea25cad2d7443f5b45a5319e2bd201048 | commitdiff |
V4L/DVB (10223): zoran: Remove global device array
The driver was keeping a global array with an entry for each zoran device
probed. It was a leftover from when the driver didn't dynamically allocate
the driver data for each device.
There was only one use left, in the video device's ->open() method, looking
up the struct zoran for the opened device from the minor number. This can
be done better with video_get_drvdata().
Since zoran_num is now only used in the pci driver's ->probe() method, it
doesn't need to be an atomic_t and be static. There is a race if multiple
zoran cards could be probed at the same time, but currently the probe
method for a given driver is single threaded.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
The driver was keeping a global array with an entry for each zoran device
probed. It was a leftover from when the driver didn't dynamically allocate
the driver data for each device.
There was only one use left, in the video device's ->open() method, looking
up the struct zoran for the opened device from the minor number. This can
be done better with video_get_drvdata().
Since zoran_num is now only used in the pci driver's ->probe() method, it
doesn't need to be an atomic_t and be static. There is a race if multiple
zoran cards could be probed at the same time, but currently the probe
method for a given driver is single threaded.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| drivers/media/video/zoran/zoran_card.c | diffblobblamehistory | |
| drivers/media/video/zoran/zoran_card.h | diffblobblamehistory | |
| drivers/media/video/zoran/zoran_driver.c | diffblobblamehistory |