| commit | 5c123e20b4e588a273b9cb16c24c3aac8cdb91b3 | |
| author | NeilBrown <neilb@suse.de> | |
| Wed, 24 Nov 2010 05:39:46 +0000 (24 16:39 +1100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 9 Dec 2010 21:32:39 +0000 (9 13:32 -0800) | ||
| tree | 270030805303dffc56749b48d2ccf6971e5b3401 | treesnapshot (tar.gz zip) |
| parent | 3743e8ce777f4f1cfa1797dc1d96a4e94b361a11 | commitdiff |
md/raid1: really fix recovery looping when single good device fails.
commit 8f9e0ee38f75d4740daa9e42c8af628d33d19a02 upstream.
Commit 4044ba58dd15cb01797c4fd034f39ef4a75f7cc3 supposedly fixed a
problem where if a raid1 with just one good device gets a read-error
during recovery, the recovery would abort and immediately restart in
an infinite loop.
However it depended on raid1_remove_disk removing the spare device
from the array. But that does not happen in this case. So add a test
so that in the 'recovery_disabled' case, the device will be removed.
This suitable for any kernel since 2.6.29 which is when
recovery_disabled was introduced.
Reported-by: Sebastian Färber <faerber@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 8f9e0ee38f75d4740daa9e42c8af628d33d19a02 upstream.
Commit 4044ba58dd15cb01797c4fd034f39ef4a75f7cc3 supposedly fixed a
problem where if a raid1 with just one good device gets a read-error
during recovery, the recovery would abort and immediately restart in
an infinite loop.
However it depended on raid1_remove_disk removing the spare device
from the array. But that does not happen in this case. So add a test
so that in the 'recovery_disabled' case, the device will be removed.
This suitable for any kernel since 2.6.29 which is when
recovery_disabled was introduced.
Reported-by: Sebastian Färber <faerber@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/md/raid1.c | diffblobblamehistory |