WATCHDOG: hpwdt: Fix kdump when using hpwdt
commit59e71f5756a5350388027b23f6ed6a40e5571bef
authorBernhard Walle <bwalle@suse.de>
Sun, 26 Oct 2008 14:59:37 +0000 (26 15:59 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 5 Dec 2008 18:55:23 +0000 (5 10:55 -0800)
tree41eb6069c62b8bca10dece829fea8a59e9c6c49c
parent56ef000707e2bea42425acf91eccef538eaf2356
WATCHDOG: hpwdt: Fix kdump when using hpwdt

commit 290172e79036fc25a22aaf3da4835ee634886183 upstream.

When the "hpwdt" module is loaded (even if the /dev/watchdog device is not
opened), then kdump does not work. The panic kernel either does not start at
all or crash in various places.

The problem is that hpwdt_pretimeout is registered with register_die_notifier()
with the highest possible priority. Because it returns NOTIFY_STOP, the
crash_nmi_callback which is also registered with register_die_notifier()
is never executed. This causes the shutdown of other CPUs to fail.

Reverting the order is no option: The crash_nmi_callback executes HLT
and so never returns normally. Because of that, it must be executed as
last notifier, which currently is done.

So, that patch returns NOTIFY_OK to keep the crash_nmi_callback executed.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Thomas Mingarelli <thomas.mingarelli@hp.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/watchdog/hpwdt.c