| commit | 5861f8e58dd84fc34b691c2e8d4824dea68c360e | |
| author | Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> | |
| Sat, 14 Mar 2009 14:23:01 +0000 (14 14:23 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 16 Mar 2009 03:09:51 +0000 (15 20:09 -0700) | ||
| tree | 5c202f6866cca91ded45213cbb1a3d7f75fc6749 | treesnapshot (tar.gz zip) |
| parent | 7cd0a63872ac6ef97265f07adc367ca4f984468e | commitdiff |
tcp: remove pointless .dsack/.num_sacks code
In the pure assignment case, the earlier zeroing is
still in effect.
David S. Miller raised concerns if the ifs are there to avoid
dirtying cachelines. I came to these conclusions:
> We'll be dirty it anyway (now that I check), the first "real" statement
> in tcp_rcv_established is:
>
> tp->rx_opt.saw_tstamp = 0;
>
> ...that'll land on the same dword. :-/
>
> I suppose the blocks are there just because they had more complexity
> inside when they had to calculate the eff_sacks too (maybe it would
> have been better to just remove them in that drop-patch so you would
> have had less head-ache :-)).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
In the pure assignment case, the earlier zeroing is
still in effect.
David S. Miller raised concerns if the ifs are there to avoid
dirtying cachelines. I came to these conclusions:
> We'll be dirty it anyway (now that I check), the first "real" statement
> in tcp_rcv_established is:
>
> tp->rx_opt.saw_tstamp = 0;
>
> ...that'll land on the same dword. :-/
>
> I suppose the blocks are there just because they had more complexity
> inside when they had to calculate the eff_sacks too (maybe it would
> have been better to just remove them in that drop-patch so you would
> have had less head-ache :-)).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/ipv4/tcp_input.c | diffblobblamehistory | |
| net/ipv4/tcp_output.c | diffblobblamehistory |