| commit | 5629236b31239dbaa182cb7eb39aad4d62278f7c | |
| author | Kulikov Vasiliy <segooon@gmail.com> | |
| Tue, 3 Aug 2010 15:44:16 +0000 (3 19:44 +0400) | ||
| committer | Matthew Garrett <mjg@redhat.com> | |
| Mon, 16 Aug 2010 15:53:44 +0000 (16 11:53 -0400) | ||
| tree | 7d89214f205ce5a98bca13a018f42eb308e4e345 | treesnapshot (tar.gz zip) |
| parent | da5cabf80e2433131bf0ed8993abc0f7ea618c73 | commitdiff |
x86: intel_ips: do not use PCI resources before pci_enable_device()
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
// </smpl>
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
// </smpl>
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
| drivers/platform/x86/intel_ips.c | diffblobblamehistory |