| commit | 4dc89133f49b8cfd77ba7e83f5960aed63aaa99e | |
| author | Eric Dumazet <eric.dumazet@gmail.com> | |
| Tue, 31 Aug 2010 07:40:16 +0000 (31 07:40 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 31 Aug 2010 20:37:06 +0000 (31 13:37 -0700) | ||
| tree | 7629fa72b5a13cbf48d43659bb396984caf7362a | treesnapshot (tar.gz zip) |
| parent | ba4fd9d8282f7f856f2287fe8be784d1dfdda28b | commitdiff |
net: add a comment on netdev->last_rx
As some driver authors seem to reintroduce dev->last_rx use,
add a comment to strongly discourage this.
Since commit 6cf3f41e6c0 (bonding, net: Move last_rx update into bonding
recv logic), network drivers dont need to update last_rx themselves,
unless they use this field to implement a timeout.
Not updating last_rx helps not dirtying a cache line, improving
performance in SMP.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
As some driver authors seem to reintroduce dev->last_rx use,
add a comment to strongly discourage this.
Since commit 6cf3f41e6c0 (bonding, net: Move last_rx update into bonding
recv logic), network drivers dont need to update last_rx themselves,
unless they use this field to implement a timeout.
Not updating last_rx helps not dirtying a cache line, improving
performance in SMP.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| include/linux/netdevice.h | diffblobblamehistory |