| commit | 4aa50bc9c2b2d5ab5c63658e0fadad03a08835cc | |
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | |
| Wed, 13 Jan 2010 11:05:45 +0000 (13 12:05 +0100) | ||
| committer | Dominik Brodowski <linux@dominikbrodowski.net> | |
| Wed, 17 Feb 2010 16:37:36 +0000 (17 17:37 +0100) | ||
| tree | 29086dc2df56bf6d1f309ed4c10cfa3664f4e0fa | treesnapshot (tar.gz zip) |
| parent | 35169529093be3bbef70afd3c4125e35cece7e03 | commitdiff |
pcmcia/bfin_cf: don't check platform_get_irq's return value against zero
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Vrabel <dvrabel@arcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Vrabel <dvrabel@arcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
| drivers/pcmcia/bfin_cf_pcmcia.c | diffblobblamehistory |