ipv4: fix the reusing of routing cache entries
commit44a41f45fb2609b37ff81dcbce186dc3f7f95fcb
authorJulian Anastasov <ja@ssi.bg>
Mon, 8 Aug 2011 05:20:20 +0000 (7 22:20 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 16 Aug 2011 01:31:37 +0000 (15 18:31 -0700)
treedf18073b39e9446d381d5cfd27c9ce4cfe2af84b
parent4339267bcded2540782c8f7587bc59434b89420c
ipv4: fix the reusing of routing cache entries

[ Upstream commit d547f727df86059104af2234804fdd538e112015 ]

compare_keys and ip_route_input_common rely on
rt_oif for distinguishing of input and output routes
with same keys values. But sometimes the input route has
also same hash chain (keyed by iif != 0) with the output
routes (keyed by orig_oif=0). Problem visible if running
with small number of rhash_entries.

Fix them to use rt_route_iif instead. By this way
input route can not be returned to users that request
output route.

The patch fixes the ip_rt_bug errors that were
reported in ip_local_out context, mostly for 255.255.255.255
destinations.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/route.c