| commit | 437f7fdb607f32b737e4da9f14bebcfdac2c90c3 | |
| author | Oleg Nesterov <oleg@redhat.com> | |
| Thu, 23 Apr 2009 23:02:45 +0000 (24 01:02 +0200) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Fri, 24 Apr 2009 14:39:45 +0000 (24 07:39 -0700) | ||
| tree | 2064149ad4406774bd3b1ade60782980206f2e82 | treesnapshot (tar.gz zip) |
| parent | 8c652f96d3852b97a49c331cd0bb02d22f3cb31b | commitdiff |
check_unsafe_exec: s/lock_task_sighand/rcu_read_lock/
write_lock(¤t->fs->lock) guarantees we can't wrongly miss
LSM_UNSAFE_SHARE, this is what we care about. Use rcu_read_lock()
instead of ->siglock to iterate over the sub-threads. We must see
all CLONE_THREAD|CLONE_FS threads which didn't pass exit_fs(), it
takes fs->lock too.
With or without this patch we can miss the freshly cloned thread
and set LSM_UNSAFE_SHARE, we don't care.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
[ Fixed lock/unlock typo - Hugh ]
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
write_lock(¤t->fs->lock) guarantees we can't wrongly miss
LSM_UNSAFE_SHARE, this is what we care about. Use rcu_read_lock()
instead of ->siglock to iterate over the sub-threads. We must see
all CLONE_THREAD|CLONE_FS threads which didn't pass exit_fs(), it
takes fs->lock too.
With or without this patch we can miss the freshly cloned thread
and set LSM_UNSAFE_SHARE, we don't care.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
[ Fixed lock/unlock typo - Hugh ]
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| fs/exec.c | diffblobblamehistory |