| commit | 41cd766b065970ff6f6c89dd1cf55fa706c84a3d | |
| author | Matthew Garrett <mjg@redhat.com> | |
| Wed, 9 Jun 2010 20:05:07 +0000 (9 16:05 -0400) | ||
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | |
| Fri, 30 Jul 2010 16:29:15 +0000 (30 09:29 -0700) | ||
| tree | f52a7346daaaad331dbd260f0e21bcf9d108b2e6 | treesnapshot (tar.gz zip) |
| parent | 4302e0fb7fa5b071e30f3cfb68e85155b3d69d9b | commitdiff |
PCI: Don't enable aspm before drivers have had a chance to veto it
The aspm code will currently set the configured aspm policy before drivers
have had an opportunity to indicate that their hardware doesn't support it.
Unfortunately, putting some hardware in L0 or L1 can result in the hardware
no longer responding to any requests, even after aspm is disabled. It makes
more sense to leave aspm policy at the BIOS defaults at initial setup time,
reconfiguring it after pci_enable_device() is called. This allows the
driver to blacklist individual devices beforehand.
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
The aspm code will currently set the configured aspm policy before drivers
have had an opportunity to indicate that their hardware doesn't support it.
Unfortunately, putting some hardware in L0 or L1 can result in the hardware
no longer responding to any requests, even after aspm is disabled. It makes
more sense to leave aspm policy at the BIOS defaults at initial setup time,
reconfiguring it after pci_enable_device() is called. This allows the
driver to blacklist individual devices beforehand.
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
| drivers/pci/pcie/aspm.c | diffblobblamehistory |