dynamic debug: move ddebug_remove_module() down into free_module()
commit40644fb1fab29e9ebfa49a1297e011c29559eacb
authorJason Baron <jbaron@redhat.com>
Tue, 27 Jul 2010 20:18:01 +0000 (27 13:18 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:29:33 +0000 (2 10:29 -0700)
treed97f6635c11aee03966a7c26052f4c7f59856d3a
parent5f0c555517928574fe2bdb68e494e245e743e132
dynamic debug: move ddebug_remove_module() down into free_module()

commit b82bab4bbe9efa7bc7177fc20620fff19bd95484 upstream.

The command

echo "file ec.c +p" >/sys/kernel/debug/dynamic_debug/control

causes an oops.

Move the call to ddebug_remove_module() down into free_module().  In this
way it should be called from all error paths.  Currently, we are missing
the remove if the module init routine fails.

Signed-off-by: Jason Baron <jbaron@redhat.com>
Reported-by: Thomas Renninger <trenn@suse.de>
Tested-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/module.c