| commit | 39aa9b6e3cb1b2a564d3422eedb7f725179162d3 | |
| author | Axel Lin <axel.lin@gmail.com> | |
| Mon, 11 Jul 2011 01:57:43 +0000 (11 09:57 +0800) | ||
| committer | Liam Girdwood <lrg@slimlogic.co.uk> | |
| Fri, 22 Jul 2011 10:41:57 +0000 (22 11:41 +0100) | ||
| tree | 4c4ab6357e1d422971212504d8cb3d441ca8d638 | treesnapshot (tar.gz zip) |
| parent | d04156bca629740a661fd0738cd69ba1f08b2b20 | commitdiff |
regulator: tps65910: Fix array access out of bounds bug
For tps65910, the number of regulator is 13. ( ARRAY_SIZE(tps65910_regs) is 13)
For tps65911, the number of regulator is 12. ( ARRAY_SIZE(tps65911_regs) is 12)
If we are using this driver for tps65911,
we hit array access out of bounds bug in tps65910_probe() because
current implementation always assume the number of regulator is 13 and
thus it will access tps65911_regs[12].
Fix it by setting correct num_regulators for both chips in tps65910_probe(),
and allocated neccessay memory accordingly.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
For tps65910, the number of regulator is 13. ( ARRAY_SIZE(tps65910_regs) is 13)
For tps65911, the number of regulator is 12. ( ARRAY_SIZE(tps65911_regs) is 12)
If we are using this driver for tps65911,
we hit array access out of bounds bug in tps65910_probe() because
current implementation always assume the number of regulator is 13 and
thus it will access tps65911_regs[12].
Fix it by setting correct num_regulators for both chips in tps65910_probe(),
and allocated neccessay memory accordingly.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
| drivers/regulator/tps65910-regulator.c | diffblobblamehistory |