| commit | 369cf77a6a3e41b1110506ddf43d45804103bfde | |
| author | Thomas Graf <tgraf@infradead.org> | |
| Thu, 11 Nov 2010 15:47:59 +0000 (11 15:47 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 12 Nov 2010 18:53:09 +0000 (12 10:53 -0800) | ||
| tree | 6bd88b669c8c68ac4d9008e00566ca15e43a6ff4 | treesnapshot (tar.gz zip) |
| parent | 8877870f8a8127b653f8c9a55c6b4de9f96f639b | commitdiff |
rtnetlink: Fix message size calculation for link messages
nlmsg_total_size() calculates the length of a netlink message
including header and alignment. nla_total_size() calculates the
space an individual attribute consumes which was meant to be used
in this context.
Also, ensure to account for the attribute header for the
IFLA_INFO_XSTATS attribute as implementations of get_xstats_size()
seem to assume that we do so.
The addition of two message headers minus the missing attribute
header resulted in a calculated message size that was larger than
required. Therefore we never risked running out of skb tailroom.
Signed-off-by: Thomas Graf <tgraf@infradead.org>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
nlmsg_total_size() calculates the length of a netlink message
including header and alignment. nla_total_size() calculates the
space an individual attribute consumes which was meant to be used
in this context.
Also, ensure to account for the attribute header for the
IFLA_INFO_XSTATS attribute as implementations of get_xstats_size()
seem to assume that we do so.
The addition of two message headers minus the missing attribute
header resulted in a calculated message size that was larger than
required. Therefore we never risked running out of skb tailroom.
Signed-off-by: Thomas Graf <tgraf@infradead.org>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/core/rtnetlink.c | diffblobblamehistory |