| commit | 35576eab390df313095306e2a8216134910e7014 | |
| author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | |
| Mon, 17 Jan 2011 00:22:47 +0000 (17 09:22 +0900) | ||
| committer | James Morris <jmorris@namei.org> | |
| Tue, 18 Jan 2011 22:53:53 +0000 (19 09:53 +1100) | ||
| tree | c35b52f6797ce69091c3e3bc596783f45e19496a | treesnapshot (tar.gz zip) |
| parent | 40c1001792de63e0f90e977eb05393fd71f78692 | commitdiff |
trusted-keys: another free memory bugfix
TSS_rawhmac() forgot to call va_end()/kfree() when data == NULL and
forgot to call va_end() when crypto_shash_update() < 0.
Fix these bugs by escaping from the loop using "break"
(rather than "return"/"goto") in order to make sure that
va_end()/kfree() are always called.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
TSS_rawhmac() forgot to call va_end()/kfree() when data == NULL and
forgot to call va_end() when crypto_shash_update() < 0.
Fix these bugs by escaping from the loop using "break"
(rather than "return"/"goto") in order to make sure that
va_end()/kfree() are always called.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
| security/keys/trusted_defined.c | diffblobblamehistory |