| commit | 3321b791b2e8897323f8c044a0c77ff25781381c | |
| author | Jeff Layton <jlayton@redhat.com> | |
| Fri, 25 Sep 2009 13:53:37 +0000 (25 09:53 -0400) | ||
| committer | Steve French <sfrench@us.ibm.com> | |
| Fri, 25 Sep 2009 17:59:31 +0000 (25 17:59 +0000) | ||
| tree | cf349723b7b4f48151d10eeaeff322c05fd9de3b | treesnapshot (tar.gz zip) |
| parent | 15dd478107fb110689ef09d276d84051b31b7e5c | commitdiff |
cifs: fix locking and list handling code in cifs_open and its helper
The patch to remove cifs_init_private introduced a locking imbalance. It
didn't remove the leftover list addition code and the unlocking in that
function. cifs_new_fileinfo does the list addition now, so there should
be no need to do it outside of that function.
pCifsInode will never be NULL, so we don't need to check for that. This
patch also gets rid of the ugly locking and unlocking across function
calls.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
The patch to remove cifs_init_private introduced a locking imbalance. It
didn't remove the leftover list addition code and the unlocking in that
function. cifs_new_fileinfo does the list addition now, so there should
be no need to do it outside of that function.
pCifsInode will never be NULL, so we don't need to check for that. This
patch also gets rid of the ugly locking and unlocking across function
calls.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
| fs/cifs/file.c | diffblobblamehistory |